fix(ui-voice): start large model pack files first and show verification progress - #608

No actionable comments were generated in the recent review. 🎉

Walkthrough

The model-pack installer now reports verified bytes separately from transferred bytes. The settings UI displays verification progress with file counts and localized accessibility labels. The progress parser includes a nullable verified-byte field, and the meter animation uses a slower linear transition.

Changes

Model-pack verification progress

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant ModelPackInstaller
  participant sha256FileHex
  participant ModelPackTransferRows
  participant MeterBar
  ModelPackInstaller->>sha256FileHex: Hash file and report verified bytes
  sha256FileHex-->>ModelPackInstaller: Cumulative hashed bytes
  ModelPackInstaller-->>ModelPackTransferRows: Transfer, verification, and file-count progress
  ModelPackTransferRows->>MeterBar: Render progress with accessibility label

Suggested reviewers: leeroybrun

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 9.09% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 10 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly summarizes the primary changes: starting large model-pack files first and showing verification progress.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description check		The description is complete and relevant. It explains the problem, changes, testing, residual risks, UI behavior, and AI assistance. It does not use the template headings and omits the checklist and s…

Full details: Description check

Explanation

The description is complete and relevant. It explains the problem, changes, testing, residual risks, UI behavior, and AI assistance. It does not use the template headings and omits the checklist and screenshots or recording, but the required information is mostly covered.

• Fix all pre-merge checks with AI

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands.}

Confidence Score: 5/5

[Medium impact] The reviewed changes appear safe to merge, with the previous progress-bar issue fixed.

Summary

Model-pack downloads start large files first and show progress while checking downloaded bytes.

• Model-pack downloads start with the largest files first.
• The settings row shows how much of a model pack has been verified.
• Progress bars glide smoothly as transfer updates arrive.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Start largest files first] --> B{File already exists?}
    B -->|Yes| C[Check file and report progress]
    C --> D{Hash matches?}
    D -->|No| E[Withdraw counted bytes]
    E --> F[Download file]
    B -->|No| F
    F --> G[Check downloaded file]
    D -->|Yes| H[Count file as done]
    G --> H
    H --> I[Continue remaining files]

_{Reviews (2) · Last reviewed commit: "fix(ui-voice): start the verification ba..." · Reviewed by Greptile}

@greptileai review — re-check at 1b63c51 (verification bar now keyed per phase; resumed-file progress fixed in 5af69e1).

Reviewed current head 1b63c51. I recommend the source change; no additional 0.2 code correction was needed.

The behavior belongs at the native manifest downloader: it schedules larger files first and distinguishes transferred bytes from checked bytes. Both initial install and update use this owner. The shared transfer row presents that progress for TTS and STT; it does not become another installer/accounting authority. The rejected-scratch accounting and phase-specific meter key already address the earlier CodeRabbit/Greptile findings. I found no remaining competing owner in the affected native corridor; the web backend does not use this native installer.

Validation: UI typecheck passed. Four regressions failed against the prior implementation as intended. The broad affected run passed 174 files/963 tests with seven setup failures caused by a missing generated protocol file; after running its canonical generator, all 77 tests in the affected rerun passed. Current-head check-runs have no failures. Native device QA was unavailable, so physical-device hashing/motion remains unverified.

The existing 0.3 port #620 needed adaptation through its evolved shared installer rather than copying the 0.2 downloader. I pushed two follow-up commits there: 92c77f5 preserves full native preparation progress and removes rejected-byte contributions; 38f3233 restarts verification when Range is ignored while retaining completed native transfer progress, and improves Spanish wording. The matching 0.3 shared package passes all 165 tests and typecheck. The whole intent and corrections are also represented in the local 0.3 line. Current-head review/CI confirmation for #620 remains separate and pending.

Thanks @danljungstrom for the source change and port.

Posted on behalf of @leeroybrun.

Thank you very much @danljungstrom ! :)